thekompanee / fuubar

The instafailing RSpec progress bar formatter
http://jeffkreeftmeijer.com/2010/fuubar-the-instafailing-rspec-progress-bar-formatter/
MIT License
955 stars 65 forks source link

Change CONTINUOUS_INTEGRATION flag to CI #83

Closed xtian closed 8 years ago

xtian commented 8 years ago

While Travis sets both CI and CONTINUOUS_INTEGRATION to true by default, Circle only sets CI to true. This change will make fuubar work out of the box on both.

More info:

jfelchner commented 8 years ago

Unfortunately my feeling is that CI is too ambiguous as it can stand for many things. While the Travis team was more than happy to add CONTINUOUS_INTEGRATION to their default build at my request, the Circle team (who I use) felt that it was too much work.

If you want to use on Circle (as I do), you can add:

machine:
  environment:
    CONTINUOUS_INTEGRATION: true

to your circle.yml file.

xtian commented 8 years ago

Ok, yeah that's what I do now. I just thought it would be nice if things worked out of the box since I invariably forget about this flag when starting a new project. I do agree with you, though.

jfelchner commented 8 years ago

Thanks for the PR though!

github-actions[bot] commented 3 years ago

This issue has been closed automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.