thekrakken / java-grok

Simple API that allows you to easily parse logs and other files

http://grok.nflabs.com/

Other

358 stars 152 forks source link

Does java-grok support "name capture only"? #39

Closed lephix closed 1 year ago

lephix commented 8 years ago

I didn't find this feature in this library. Could you figure it out for me ?

palmerabollo commented 8 years ago

+1, this would be useful. Any plans to include it in java-grok?

anthonycorbacho commented 8 years ago

Hi, sadly i dont have time to implement more feature. If someone can create a PR, I will gladly review and merge it.

trixpan commented 7 years ago

@lephix @palmerabollo - mind explaining what do you mean by "name capture only"? Happy to have a go in trying to address it.

Cheers

palmerabollo commented 7 years ago

@trixpan It means to capture named expressions only or not (i.e. %{IP:ip} but not ${IP}). It's a quite common option (see for example https://grokdebug.herokuapp.com/) because in many occasions you don't want to get all the intermediate expressions a grok match contains.

The good part is that I think it was fixed in this PR https://github.com/thekrakken/java-grok/pull/45/files

trixpan commented 7 years ago

@palmerabollo so this can be closed?

palmerabollo commented 7 years ago

Yes, I think so.

fbacchella commented 7 years ago

But if fails in some case, see issue #61.

retoo commented 7 years ago

I created a PR https://github.com/thekrakken/java-grok/pull/70 which should improve the situation described by @fbacchella

retoo commented 7 years ago

70 is merged, the discussed problems should be fixed.