thekrakken / java-grok

Simple API that allows you to easily parse logs and other files
http://grok.nflabs.com/
Other
360 stars 151 forks source link

Grok Compiler: wrap grok patterns in (?:...) in namedOnly mode #70

Closed retoo closed 7 years ago

retoo commented 7 years ago

This ensures that the namedOnly behaves similar like the normal mode.

i.E.

WORD foo|bar
TEXT %{WORD}+

=> should render to (?:foo|bar)+and NOT foo|bar+

Fixes https://github.com/thekrakken/java-grok/issues/61

anthonycorbacho commented 7 years ago

Thanks for your contribution, LGTM :)

anthonycorbacho commented 7 years ago

@retoo there is conflict on your branch, can you rebase from master?

I will merge it once it is done.

Thanks~

retoo commented 7 years ago

@anthonycorbacho if resolved the conflict, you can merge this PR.