search

thekrakken / java-grok

Simple API that allows you to easily parse logs and other files
http://grok.nflabs.com/
Other
360 stars 151 forks source link

add option to keep empty captures #79

Closed ottobackwards closed 6 years ago

ottobackwards commented 6 years ago

Per: https://www.elastic.co/guide/en/logstash/current/plugins-filters-grok.html#plugins-filters-grok-keep_empty_captures

This change is Reviewable

ramondg commented 6 years ago

+1

fbacchella commented 6 years ago

This repo is almost dead, no one will merge it. See https://github.com/thekrakken/java-grok/pull/73 for more discussions about that.

anthonycorbacho commented 6 years ago

Hi,

Sorry for the silence, i am ultra busy at work

Can you fix the unit test. Lets merge it asap.

ottobackwards commented 6 years ago

I've tracked the changes from this morning, and updated to use the check style and intellij styles. I also started building with gradle as opposed to mvn, to get the checkstyle to run locally

anthonycorbacho commented 6 years ago

@ottobackwards i am sorry, i bring conflict, can you rebase and ping me back so i can merge it

ottobackwards commented 6 years ago

Done.

ottobackwards commented 6 years ago

Does this need to be re-submitted?

anthonycorbacho commented 6 years ago

The logic changed a little bit between the merge back. If you have time can you take a look? I can also help let me know

On Thu, 19 Apr 2018 at 5:47 AM ottobackwards notifications@github.com wrote:

Does this need to be re-submitted?

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/thekrakken/java-grok/pull/79#issuecomment-382524031, or mute the thread https://github.com/notifications/unsubscribe-auth/AC_n5T-umfTaVnFopxho0wC979CS7cmHks5tp6ZKgaJpZM4TSJVm .