search

thekrakken / java-grok

Simple API that allows you to easily parse logs and other files
http://grok.nflabs.com/
Other
360 stars 151 forks source link

GrokeCompiler can register an InputStream but not a Reader #85

Closed fbacchella closed 6 years ago

fbacchella commented 6 years ago

GrokeCompiler can register an InputStream but convert it using an hard coded charset. Adding GrokeCompiler.register(Reader) so developper can manage that themselves.

ottobackwards commented 6 years ago

Can you resolve the check style errors?

ottobackwards commented 6 years ago

This looks good, can you create some unit test coverage for these changes?

fbacchella commented 6 years ago

Done.

anthonycorbacho commented 6 years ago

Awesome, change look good to me. I am making a PR to fix previous rebase, would you be okay to rebase your branch after? I will merge it when ci is green

anthonycorbacho commented 6 years ago

I just merged #91 and it fixes the previous checkstyle issue. After ci is green, lets merge.

fbacchella commented 6 years ago

Done.