search

thekrakken / java-grok

Simple API that allows you to easily parse logs and other files
http://grok.nflabs.com/
Other
360 stars 151 forks source link

GrokCompiler.compile don't document unchecked exception. #86

Closed fbacchella closed 6 years ago

fbacchella commented 6 years ago

GrokCompiler.compile should document exception it throws, even unchecked one. I think it helps tools like Eclipse to auto-generate code.

ottobackwards commented 6 years ago

Since this is a runtime exception, adding the throws does not require a change to callers who may not have been catching, so +1 from me, but you need to fix the check style errors

fbacchella commented 6 years ago

I don't think the style failure are mine.

anthonycorbacho commented 6 years ago

I am sorry, this is my fault, i did something wrong with the rebase, i will fix it. Can you rebase your branch, #91 fixes the previous checkstyle issue

fbacchella commented 6 years ago

Done.

anthonycorbacho commented 6 years ago

Arf, it bring conflict again by merging the other pr :(

fbacchella commented 6 years ago

Done.