search

thekrakken / java-grok

Simple API that allows you to easily parse logs and other files
http://grok.nflabs.com/
Other
360 stars 151 forks source link

grokCompiler default to UTC #87

Closed fbacchella closed 6 years ago

fbacchella commented 6 years ago

When grokCompiler is asked to compile without a timezone defined, it should default to the current timezone. Not the UTC timezone. I don't think that when people don't request for a timezone, they think about UTC. They rather think about the local timezone.

ottobackwards commented 6 years ago

Is there an actual problem with the defined behavior? Changing the defined behavior when it has been working isn't necessary a good thing.

fbacchella commented 6 years ago

GrokCompiler is new, has never be released. So I don't think there is a changing behavior here.

ottobackwards commented 6 years ago

oops, sorry

anthonycorbacho commented 6 years ago

Change lgtm, can you rebase your branch from master? #91 fixes the previous checkstyle issue.

fbacchella commented 6 years ago

Done.