thekrakken / java-grok

Simple API that allows you to easily parse logs and other files
http://grok.nflabs.com/
Other
358 stars 152 forks source link

GrokException or IOException or UncheckedIOException #88

Open fbacchella opened 6 years ago

fbacchella commented 6 years ago

At (https://github.com/thekrakken/java-grok/blob/95dc26ed4273c1e413b93d1ccb3d0a7b9b0ad0f2/src/main/java/io/krakens/grok/api/GrokCompiler.java#L73)

    try (Reader reader = new InputStreamReader(inputStream)) {
      register(inputStream);
    } catch (IOException e) {
      throw new GrokException(e.getMessage(), e);
    }

Whats the purpose of this wrapping ? It's a "real" IOException. If you don't like checked exceptions, then UncheckedIOException for that use case.