search

thekrakken / java-grok

Simple API that allows you to easily parse logs and other files
http://grok.nflabs.com/
Other
360 stars 151 forks source link

RuntimeException or GrokException in Match #89

Open fbacchella opened 6 years ago

fbacchella commented 6 years ago

https://github.com/thekrakken/java-grok/blob/95dc26ed4273c1e413b93d1ccb3d0a7b9b0ad0f2/src/main/java/io/krakens/grok/api/Match.java#L146

I'm not a big fan of the too generic RuntimeException. It make error dispatch using smart try ... catch difficult. Why not a GrokException here ?

anthonycorbacho commented 6 years ago

+1 for using GrokException