slf4j is not used. - Githubissues

thekrakken / java-grok

Simple API that allows you to easily parse logs and other files

http://grok.nflabs.com/

Other

360 stars 151 forks source link

slf4j is not used. #90

Closed fbacchella closed 6 years ago

fbacchella commented 6 years ago

Removing it break nothing. Did I miss a special use case ?

anthonycorbacho commented 6 years ago

Hi,

For now i am okay to remove it, but i think we should log Grok event in the future. What do you think?

fbacchella commented 6 years ago

I'm not sure. grok is not an heavy library and exception might be enough to communicate with callers. Unless more debugging informations are needed. But I don't know where.

fbacchella commented 6 years ago

Done.