thekvs / radiotray-lite

Online radio streaming player with minimum interface that runs on a Linux system tray
Other
50 stars 6 forks source link

Support bookmarks directly in the root group #17

Closed axel-h closed 6 years ago

axel-h commented 6 years ago

Seems bookmarks directly in the root group are ignored, every bookmarked radio station must be in a group. Can't you change this, so some "favorites" can be put at the top level?

thekvs commented 6 years ago

Are you sure that it is ignored? Just placed one station into "root" group and everything seems to work.

axel-h commented 6 years ago

Hm, that is strange then. I took the package from https://www.ubuntuupdates.org/package/webupd8/xenial/main/base/radiotray-lite that says v0.2.18. And with

<bookmarks>
    <group name="root">
        <group name="dummy">
            <bookmark name="foo" url="http://inter.net/foo"/>
        </group>
        <bookmark name="missing" url="http://inter.net/missing"/>
    </group>
</bookmarks>

I can see the "dummy" group only. But then this group contains "foo" and "missing"

thekvs commented 6 years ago

Ahh, I see now whats going on. It works as expected only when you put bookmark that doesn't belong to any group at the beginning of the 'root' group, i.e.

<bookmarks>                                                                                                                                        
    <group name="root">                                                                                                                            
        <bookmark name="missing" url="http://inter.net/missing"/>                                                                                  
        <group name="dummy">                                                                                                                       
            <bookmark name="foo" url="http://inter.net/foo"/>                                                                                      
        </group>                                                                                                                                   
    </group>                                                                                                                                       
</bookmarks>

This is certainly a strange behavior. Thanks for reporting.

axel-h commented 6 years ago

Actually, I'd expect that the order in the file is also the display order. So entries at the beginning of are displayed at the top and the entries at the end are at the bottom (and thus just the minimal mouse-move distance from the tray icon). Since entries can be a separator line also, they should work even in between groups and show up exactly where they are placed.