search

thelastWallE / OctoprintKlipperPlugin

A plugin for a better integration of Klipper into OctoPrint.
GNU Affero General Public License v3.0
65 stars 14 forks source link

Added feature for a horizontal line between macro buttons #28

Closed thelastWallE closed 3 years ago

thelastWallE commented 3 years ago

This adds a feature for a horizontal line between macro buttons on the sidebar and on the klipper tab. Also worked on the macrolist to distinguish the macros better apart.

One can then just name macros with "HLine" and it will display a <hr> line at this position in the list of buttons. I added a button to insert automatically a new macro with "HLine" as the name. Also i got borders, like these in the OctoKlipper-log, around the macros in the settings for OctoKlipper to distinguish them better.

The container-less knockout is only working like that. I tried other things like <!-- ko if: sidebar && name() != "HLine" --> But it didn't worked with that. I also tried to get a whole <!-- ko if: tab --> around the other conditions but it didn't work.

I want to say that this is my first ever pull request on github. So bear with me.

closes #27

AliceGrey commented 3 years ago

@thelastWallE This isn't something I see as necessary to the functionality of the plugin. If other users would also like this functionality I might consider merging it in the future but for now I'm going to leave it open for comments.

thelastWallE commented 3 years ago

looks like i stuck with this branch name now into eternity.