Plugin currently allows the user to set any string of characters to be their log file without any validation or sanity checking.

thelastWallE / OctoprintKlipperPlugin

A plugin for a better integration of Klipper into OctoPrint.

GNU Affero General Public License v3.0

65 stars 14 forks source link

Plugin currently allows the user to set any string of characters to be their log file without any validation or sanity checking. #3

Closed AliceGrey closed 3 years ago

AliceGrey commented 4 years ago

Plugin currently allows the user to set any string of characters to be their log file without any validation or sanity checking.

Steps to re-create: Open Octoprint Settings Select OctoKlipper Type in anything for klipper log path or just delete it entirely Hit save

thelastWallE commented 3 years ago

For now i have made it so that the warning popup would trigger when the log file would be needed. This is only the case on the dialog for the "Performance Graph".