thelastWallE / OctoprintKlipperPlugin

A plugin for a better integration of Klipper into OctoPrint.
GNU Affero General Public License v3.0
65 stars 14 forks source link

Klipper sidepane won't expand #35

Closed adman953 closed 3 years ago

adman953 commented 3 years ago

Before submitting your issue please make sure to provide the following information

About your environment:

octoprint (1).log

the octoKlipper side pane shows up but won't expand. i have tried disabling all of my addons and it still won't expand, it's very handy for the macros i have set up. thank you

thelastWallE commented 3 years ago

In your logfile is an error message about plugin filamentmanager every time octoprints boots. Can you look if it is really disabled?

adman953 commented 3 years ago

It is actually installed, I reinstalled it and uninstalled it with clean up data but that did nothing

On Fri, Mar 5, 2021, 2:57 PM thelastWallE notifications@github.com wrote:

In your logfile is an error message about plugin filamentmanager every time octoprints boots. Can you look if it is really disabled?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AliceGrey/OctoprintKlipperPlugin/issues/35#issuecomment-791647190, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFTG2JWAFINUZJDRB4UKMPDTCEZRXANCNFSM4YNL2FJQ .

thelastWallE commented 3 years ago

Can you provided a logfile? Have also the option debug on. And it woud help to enable the extra klipper logmessages. logging

adman953 commented 3 years ago

here is the new log octoprint.log https://drive.google.com/file/d/1x-gUbZyJ8s50mRHojd7cKlmYntIfLEnz/view?usp=drive_web

On Fri, Mar 5, 2021 at 7:46 PM thelastWallE notifications@github.com wrote:

Can you provided a logfile? Have also the option debug on. And it woud help to enable the extra klipper logmessages. [image: logging] https://user-images.githubusercontent.com/12502210/110188773-28e24180-7e1d-11eb-9724-3935993a09d4.jpeg

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AliceGrey/OctoprintKlipperPlugin/issues/35#issuecomment-791817723, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFTG2JS2YJCLALWQYRMUSDDTCF3ORANCNFSM4YNL2FJQ .

adman953 commented 3 years ago

thanks for all of the help but i figured out it was octoscreen. some sort of conflict there but i cant find exactly what.

thelastWallE commented 3 years ago

i will look into that if i have time. don't forget to switch the loglevel from debug to a normal level again.

thelastWallE commented 3 years ago

They are actively hiding the connection panel of octoklipper. https://github.com/Z-Bolt/OctoPrint-Z-Bolt-OctoScreen/blob/32f6672beefa4fd28055759bd73b6493a7b369d1/octoprint_zbolt_octoscreen/static/js/zbolt.js#L41

 ZBoltOctoScreen.ConnectionViewModel = function (parameters) {
        var self = this;

        self.onAfterBinding = function () {
            var connection = $("#sidebar_plugin_klipper");
            connection.collapse("hide");
        }
    }

I don't know why they are doing this, but I did find the problem. The accordion menu is not expanding if the site was loaded with the menu collapsed. This seems maybe to be also a problem with the whole octoprint accordion menu.

thelastWallE commented 3 years ago

I changed the eventfiring a bit back for their hiding of the sidebarmenu. It is now hiding the menu on the first siteloading and you can expand it afterwards again. If you need it somehow other i would recommend to talk to the https://github.com/Z-Bolt/OctoPrint-Z-Bolt-OctoScreen dev-team. My changes are here: https://github.com/thelastWallE/OctoPrint-Z-Bolt-OctoScreen/tree/klippersidebar

You can install it in Octoprint if you use the URL option for installation: https://github.com/thelastWallE/OctoPrint-Z-Bolt-OctoScreen/archive/klippersidebar.zip But If the original repository gets an update the changes would then again be overwritten.

thelastWallE commented 3 years ago

@adman953 Changes got merged into original OctoPrint-Z-Bolt-OctoScreen. You can install it like you did before over URL: https://github.com/Z-Bolt/OctoPrint-Z-Bolt-OctoScreen/archive/master.zip