thelastWallE / OctoprintKlipperPlugin

A plugin for a better integration of Klipper into OctoPrint.
GNU Affero General Public License v3.0
65 stars 14 forks source link

[FR] Klipper "language" coloring #45

Closed Sineos closed 3 years ago

Sineos commented 3 years ago

Thanks for keeping up the work on this plugin. Your additions and improvements are really appreciated.

I really do like the new editor with its language coloring scheme. If possible, I have two requests:

Thanks for considering.

thelastWallE commented 3 years ago

I work on a "zooming" function there you can increase and decrease the font-size.
As for the Save_Config Section this would be lower priority. Problem is that these lines are comments. These lines unfortunately start all with #*# . And i would have to do some work to distinguish between comments and real options that klipper are reading.

Sineos commented 3 years ago

Thanks for your comments. Any improvement is appreciated. My, maybe naive, idea was to distinguish between a single # as comment and #*# as Klipper SAVE_CONFIG in the parsing.

thelastWallE commented 3 years ago

You can test a first zooming function on the release candidate channel. How to use the release channels to help test release candidates https://github.com/thelastWallE/OctoprintKlipperPlugin/releases/tag/0.3.8rc2

Sineos commented 3 years ago

Works nicely on my side. Setting is saved as well and survives Octoprint restarts. Many thanks.

thelastWallE commented 3 years ago

SAVE_CONFIG section should now have a syntax highlight with 0.3.8rc3

Sineos commented 3 years ago

Works. Many thanks. 👍

Just one small cosmetic thing: grafik

TBH, not worth any additional efforts