search

thelastflapjack / godot_open_target_shooter

An open source third person shooter time trial game made with Godot 3.5
MIT License
50 stars 6 forks source link

Small improvements to music manager #6

Closed DissonantVoid closed 2 years ago

DissonantVoid commented 2 years ago

-added Tracks.None enum for invalid track id -removed cross_fade option since it had no practical use -cleaned the tween usage in _track_fade by using tween chaining (Note that you don't have to reassign a tween to apply change) also used TRANS_SINE instead of TRANS_EXPO and changed lowest volum to -20 to make audio fading more seamless, based on this cheat sheet

still working on music as of now...

DissonantVoid commented 2 years ago

I was planning to work on the music manager, but you did it first :), I do like the clean implementation though.