thelastpickle / cassandra-medusa

Apache Cassandra Backup and Restore Tool
Apache License 2.0
266 stars 143 forks source link

Update GRPC_HEALTH_PROBE_VERSION to version 0.4.25 #724

Closed AlexsandroRotundo closed 8 months ago

AlexsandroRotundo commented 8 months ago

Update GRPC_HEALTH_PROBE_VERSION to version 0.4.25

github-actions[bot] commented 8 months ago

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

AlexsandroRotundo commented 8 months ago

Issue: https://github.com/thelastpickle/cassandra-medusa/issues/725

AlexsandroRotundo commented 8 months ago

I pushed a stupid modification about the upgrade of the GRPC HEALTH PROBE VERSION. Unfortunately, I got a pipeline failure in these tests:

  k8ssandra-e2e-tests:
    needs: [build]
    runs-on: ubuntu-latest
    strategy:
      matrix:
        e2e_test:
          - CreateSingleMedusaJob
          - CreateSingleDseSearchDatacenterCluster
      fail-fast: false
    name: k8ssandra-${{ matrix.e2e_test }}
    env:
      CGO_ENABLED: 0
      KUBECONFIG_FILE: "./build/kind-kubeconfig"
      CONTROL_PLANE: kind-k8ssandra-0
      DATA_PLANES: kind-k8ssandra-0
    steps:
      - name: Raise open files limit
        run: |
          echo fs.file-max=1000000 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p
          echo fs.inotify.max_user_instances=1280 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p
          echo fs.inotify.max_user_watches=655360 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p
          ulimit -a
      - name: Free diskspace by removing unused packages
        run: |
          sudo rm -rf /usr/local/lib/android
          sudo rm -rf /usr/share/dotnet
      - name: Set up Docker Buildx
        uses: docker/setup-buildx-action@v1
      - name: Login to DockerHub
        uses: docker/login-action@v2
        with:
          username: ${{ secrets.K8SSANDRA_DOCKER_HUB_USERNAME }}
          password: ${{ secrets.K8SSANDRA_DOCKER_HUB_PASSWORD }}

I believe that username and password are missing in the secret configuration of my fork. Someone could help me to fix this problem to contribute in the maintenance of the project, please?

Thank you in advance.

adejanovski commented 8 months ago

Hi @AlexsandroRotundo, external PRs aren't allowed to access secrets indeed. I'll push a branch based on your PR to get CI running.

adejanovski commented 8 months ago

Here it is.