Fix backup man future registration and BackupStatus computation of the node backup state

thelastpickle / cassandra-medusa

Apache Cassandra Backup and Restore Tool

Apache License 2.0

266 stars 143 forks source link

Fix backup man future registration and BackupStatus computation of the node backup state #799

Closed adejanovski closed 3 months ago

adejanovski commented 3 months ago

Fixes #797

Two bugs are fixed in this PR:

The BackupMan.register_backup() function was always registering the backup, even if it existed and overwrite was set to false due to bad code structure.
The state was computed without taking into account the presence of a future. In case of a restart of the grpc server with an unfinished backup job, the backup would forever be seen as in progress even though it failed.

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

adejanovski commented 3 months ago

@rzvoncek, this is ready for review. I added some tests to check the behavior and manually checked that it works as expected in K8ssandra. There are 2 failing tests which seem unrelated but I'll leave that up to you to decide (one seems to be a gcs communication issue and the other a webhook issue).

rzvoncek commented 3 months ago

I've retriggered the tests and they both passed.