thelastpickle / cassandra-reaper

Automated Repair Awesomeness for Apache Cassandra
http://cassandra-reaper.io/
Apache License 2.0
489 stars 217 forks source link

Should we perform a decommission of the following log - RepairRunner - RepairRun #1178

Open carvalhoj3 opened 2 years ago

carvalhoj3 commented 2 years ago

Project board link

Hey guys, makes sense to do decommission of the following log message?

WARN [2022-02-28 23:07:53,650] [collectors-data-store:39ad4a30-98ea-11ec-a43e-ab4114631cf6] i.c.s.RepairRunner - RepairRun "39ad4a30-98ea-11ec-a43e-ab4114631cf6" does not exist. Killing RepairRunner for this run instance.

The reports messages leads to some misunderstanding, make us thinking that maybe the repair was not performed or didn't run. But it actually only reports each time a repair finishes that the repair have run and finished. And is not actually any kind of error.

K.

┆Issue is synchronized with this Jira Story by Unito ┆Issue Number: REAP-93

adejanovski commented 2 years ago

I think this should be moved to INFO level instead as it's expected to get this message. It could be interesting to modify the message to point out the repair run has ended instead of "does not exist" (both cases can be distinguished in the code, so we can write the appropriate message).