search

thelastpickle / cassandra-reaper

Automated Repair Awesomeness for Apache Cassandra
http://cassandra-reaper.io/
Apache License 2.0
490 stars 218 forks source link

Improve Prometheus metrics #1198

Closed colltoaction closed 1 year ago

colltoaction commented 2 years ago

According to the Prometheus best practices:

Use labels to differentiate the characteristics of the thing that is being measured. Do not put the label names in the metric name, as this introduces redundancy and will cause confusion if the respective labels are aggregated away.

In the case of reaper, this best practice is ignored. See:

https://github.com/thelastpickle/cassandra-reaper/blob/ac58595266ea426bc52c7abef969fb5a189b72a7/src/server/src/main/java/io/cassandrareaper/service/RepairRunner.java#L751

My team owns a reaper instance but we can't easily relabel metrics. We don't host Prometheus but rely on another team that provides it as a service for the whole company.

┆Issue is synchronized with this Jira Task by Unito ┆friendlyId: K8SSAND-1531 ┆priority: Medium

adejanovski commented 2 years ago

Hi @colltoaction,

we're very close to merging a PR that will expose native Prometheus metrics: https://github.com/thelastpickle/cassandra-reaper/pull/974

Things should get much better with it.

colltoaction commented 2 years ago

I see it is merged :). Is there any pre release version I can use to test?

adejanovski commented 2 years ago

Yes, the latest beta was built off master: https://cloudsmith.io/~thelastpickle/repos/reaper-beta/packages/

adejanovski commented 2 years ago

Also, the docker images are available: https://hub.docker.com/repository/docker/thelastpickle/cassandra-reaper/tags?page=1&ordering=last_updated

adejanovski commented 1 year ago

Fixed and released through https://github.com/thelastpickle/cassandra-reaper/pull/974