search

thelastpickle / cassandra-reaper

Automated Repair Awesomeness for Apache Cassandra
http://cassandra-reaper.io/
Apache License 2.0
487 stars 217 forks source link

Remove diagnostic events logic #1351

Open Miles-Garnsey opened 1 year ago

Miles-Garnsey commented 1 year ago

Project board link

The JmxCassandraManagementProxy currently contains a fair bit of logic which is used only by the diagnostic events subsystem. Diagnostic events are only relevant for Cassandra developers, and they cause some issues because we do not have capacity to maintain them in Reaper at present.

As a result, we are unable to support them using the new HTTP management proxy, and this is causing divergences between the HTTP and JMX management proxies which are complicating the codebase.

As a result, we would like to remove diagnostic events from Reaper.

Definition of done

┆Issue is synchronized with this Jira Story by Unito

adejanovski commented 1 year ago

I assume it would be simpler to remove the diagnostic events feature altogether? What would you think about doing this instead?

Miles-Garnsey commented 1 year ago

I assume it would be simpler to remove the diagnostic events feature altogether? What would you think about doing this instead?

I haven't evaluated the idea, but I'd assume so. Removing diagnostic events is also a fine option, from my understanding they are just used for debugging JMX connection/disconnection etc. correct?

adejanovski commented 1 year ago

They're made to subscribe to Cassandra internal events (schema changes, operations, etc...) and should mostly be used by Cassandra developers. I think it's safe to assume that no one uses it.

Miles-Garnsey commented 1 year ago

They're made to subscribe to Cassandra internal events (schema changes, operations, etc...) and should mostly be used by Cassandra developers. I think it's safe to assume that no one uses it.

I'll defer to whatever you think is best on this - removal is also fine with me. I'll retitle this ticket to reflect that removing diagnostic events is our intention here.