search

thelastpickle / cassandra-reaper

Automated Repair Awesomeness for Apache Cassandra
http://cassandra-reaper.io/
Apache License 2.0
481 stars 217 forks source link

Add mTLS settings to ApiClient #1415

Closed burmanm closed 5 months ago

burmanm commented 9 months ago

This can't hot reload yet existing connections, as that requires the connection parameters modifications to be merged first (to use caching). And as such, no such code makes sense before that's done as it would be rewritten.

Fixes #1449

burmanm commented 7 months ago

Changed base and rebased.

Miles-Garnsey commented 5 months ago

For some reason the tests aren't running here by the way, hopefully just a GHA glitch and once you add a test for the new functionality they'll run.

adejanovski commented 5 months ago

For some reason the tests aren't running here by the way, hopefully just a GHA glitch and once you add a test for the new functionality they'll run.

Tests didn't run because the target branch wasn't master. I think we need a new commit to be pushed so that CI triggers.

adejanovski commented 5 months ago

@burmanm, as discussed here's the path forward with this PR:

Modify the http-api integration test suite to use TLS all the time. That'll require adding the encryption related files in tree and modifying these lines to start the mgmt api server with TLS enabled. Then modify the Reaper configuration for the http api reaper config to set up TLS in Reaper for these tests. We'll create a subsequent ticket to add a set of test to the matrix without TLS enabled (out of scope for this ticket then).

cc @Miles-Garnsey

adejanovski commented 5 months ago

@Miles-Garnsey this is ready for another review. Thanks!

Miles-Garnsey commented 5 months ago

We still have a failing test on this one.