search

thelastpickle / cassandra-reaper

Automated Repair Awesomeness for Apache Cassandra
http://cassandra-reaper.io/
Apache License 2.0
481 stars 216 forks source link

Upgrade dropwizard.version to 2.1.0 #1481

Closed FieteO closed 3 months ago

FieteO commented 3 months ago

Bump dropwizard.version to 2.1.12. Fixes #1462

FieteO commented 3 months ago

@adejanovski It looks like the setup of the tmate session is timing out. Is this related to my changes, or some flakiness in the Actions workflow?

adejanovski commented 3 months ago

@adejanovski It looks like the setup of the tmate session is timing out. Is this related to my changes, or some flakiness in the Actions workflow?

tmate stays open for 30 minutes and then times out to allow the workflow to end. Nothing misbehaving here, the core issue is in the breakage that the dropwizard upgrade created.

FieteO commented 3 months ago

Ah, I didn't see the failing test step before. Is there any way of running these (integration?) tests locally?

I tried to invoke TEST_TYPE=ccm ./.github/scripts/run-tests.sh but that fails with not finding the ccm executable. I guess I could install that, but it would likely still fail right?

FieteO commented 3 months ago

2.1.0 seems to work now. Shall I try to bump it to the last patch version 2.1.12 @adejanovski ?

adejanovski commented 3 months ago

2.1.0 seems to work now. Shall I try to bump it to the last patch version 2.1.12 @adejanovski ?

That seems like a good idea. Thanks for handling this @FieteO !