search

thelastpickle / cassandra-reaper

Automated Repair Awesomeness for Apache Cassandra
http://cassandra-reaper.io/
Apache License 2.0
490 stars 218 forks source link

Segment count for incremental repairs remains 1 per node regardless of the segment count specified (3.2.0 + ) #1502

Closed Valgar closed 4 months ago

Valgar commented 6 months ago

Project board link

When specifying segment count for incremental repairs in repair, the value seems to be ignored (including any defaults set in config)

Unsure if this is expected behaviour, as segment count/node can be specified for full repairs.

This causes failures and backoffs during incrementals on large segments.

Screenshots of launching incremental repair and specifying segment count/node and the resulting segment count of the running repair (3 node cluster 1 per node only, instead of 64 per node)

reaper3 2 0-incremental-repair-config reaper3 2 0-incremental-repair-running
adejanovski commented 5 months ago

We will introduce a new "Subrange incremental" type of repair to cover this case. I think there are cases where a global incremental will work better than the subrange version, and vice versa.