thelastpickle / cassandra-reaper

Automated Repair Awesomeness for Apache Cassandra
http://cassandra-reaper.io/
Apache License 2.0
488 stars 217 forks source link

Opportunity to change intensity during execution #301

Closed kipwoker closed 6 years ago

kipwoker commented 6 years ago

Hello.

I want to change intensity during execution. I have a highload cassandra cluster during 8 working hours every weekday. During working hours I want to have small intensity, like 0.2. During maintenance window (night, day off) I want to have intesity like 0.8.

Am I right that there is no way to do it with autoScheduling? Should I make a pull request for this feature?

adejanovski commented 6 years ago

Hi @kipwoker,

I confirm that intensity is a fixed value for each repair run and cannot currently vary based on the current time. Any PR to add that feature would be much appreciated indeed :)

How far do you see this going in flexibility ? Would you add just 2 possible intensities with 2 time ranges for each repair ? Or add a high load and a low load time range on the clusters, and then 2 distinct intensities for repair run ?

kipwoker commented 6 years ago

@adejanovski I want to do it very flexible. :) Actually I just want to implement feature: «Change intesity when repair paused» After that I can do whatever I want though using api + cron. It's very flexible. Also for web interface I see it like this intensity

  1. If pressed «Pause» button, show «Edit» button.
  2. If pressed «Edit» button, show settings which can be changed (for now only intensity)
  3. If field with value blurred, send ajax query to server with new value
  4. If activate button pressed again, repair run again but with new settings

What do you mind about this?

kipwoker commented 6 years ago

I've tried to make something. You may check it out: https://github.com/kipwoker/cassandra-reaper/commit/bdb3947aa6734bc998113d5fcc0171d0eec4efd6

adejanovski commented 6 years ago

Merged as part of #303