search

thelastpickle / cassandra-reaper

Automated Repair Awesomeness for Apache Cassandra
http://cassandra-reaper.io/
Apache License 2.0
489 stars 217 forks source link

Deleting schedule gives confusing error message #544

Open a1exsh opened 6 years ago

a1exsh commented 6 years ago

Project board link

When one tries to delete a repair schedule, an error message like the following is shown: Repair schedule c87975b0-4491-11e8-9602-9756d0798e38 currently running. Must be first stopped.

This is confusing, because a schedule cannot be "running". It can be "active" or "inactive". A repair can be running, so immediately one checks if a repair is running for this schedule and if there is none, the confusion increases.

I propose to change the wording to "Repair schedule %s is currently active. Must be first deactivated." Also it would make sense to change the available controls for schedule to "Deactivate/Activate" instead of "Stop/Activate".

┆Issue is synchronized with this Jira Story by Unito ┆Issue Number: REAP-166

michaelsembwever commented 6 years ago

+1

lapo-luchini commented 3 years ago

I was just about to open a bug to say that I have no repairs running relative to that schedule, this is a bug. But you're right, it's just a problem in wording. 😅