thelastpickle / cassandra-zipkin-tracing

With Cassandra-3.4+ the tracing implementation can be replaced with zipkin tracing as provided by this project.
Apache License 2.0
47 stars 11 forks source link

Sending data in zipkin v2 format #11

Open jake-codes opened 5 years ago

jake-codes commented 5 years ago

Having this send out data in this latest v2 format would be a huge help, if possible.

michaelsembwever commented 5 years ago

I would be more than happy to look over any patch or PR contributed, that's the best I can do for now. (You may also find that there's more momentum in the brave-cassandra project.)

jake-codes commented 5 years ago

Gotcha. Yeah, I'm not as familiar with Zipkin as I should be but will keep that in mind. Also, Brave Cassandra doesn't report the query details like this tracing instrumentation.

codefromthecrypt commented 5 years ago

@jake-codes parsing etc is a just a feature waiting to be enabled. Mainly the zipkin one is parsimonious by default.

jake-codes commented 5 years ago

@adriancole Are you saying that Brave Cassandra can show the raw query details by enabling some setting? If so, would you mind showing an example. I can move this question to another location if more appropriate.

codefromthecrypt commented 5 years ago

No what I mean is that brave-cassandra has an issues list where features can be requested and implemented. Parsing is a routine ask, but we only implement things asked. Also, you may be in a position to help implement what you are asking for.. not sure.

At any rate, this project is less likely to be maintained and released (momentum), so I would recommend same as mick said, which is to ask specifically what you need in brave-cassandra, if not helping to implement that.

jake-codes commented 5 years ago

I can post an issue in Brave Cassandra.