search

theleagueof / fontship

A font development toolkit and collaborative work flow.
GNU Affero General Public License v3.0
91 stars 7 forks source link

Libertinus build error #127

Closed ivo-s closed 3 years ago

ivo-s commented 3 years ago

Github workflow pulls the newest Fontship and that causes an error even with commits where there was none before (I checked). There seems to be a Python module unidecode missing somewhere. https://github.com/ivo-s/libertinus/runs/1671895283

I am just guessing this is a FontShip bug, because I didn't find any package configuration in the Libertinus workflow file.

alerque commented 3 years ago

Thanks for this report. I'm pretty sure this is an Arch Linux packaging bug with Python modules that got updated without catching dependency changes, but try to chase it down and we can I'll keep this open to track confirming that it gets fixed for Fontship Docker builds.

The fact that this shows up at all is a side effect of the out-of-sync release mentioned here where latest is not actually the same as v0.7.2, it doesn't have quite the same version of dependencies baked in, and it didn't get the same testing at build time.

alerque commented 3 years ago

Confirmed my hunch, this is related to gftools. In fact it's not even an Arch package issue so much as a straight up gftools bug, their requirements.txt file is completely out of sync with what it actually needs to run the refactored latest releases. I've submitted a fix upstream but I'll also monkey patch the Arch packaging ahead of time to get this fixed for Fontship CI runs.