search

theleagueof / fontship

A font development toolkit and collaborative work flow.
GNU General Public License v3.0
98 stars 7 forks source link

Use ‘,’ instead of ‘#’ as delimiter in sed’s “s” command #69

Closed d125q closed 4 years ago

d125q commented 4 years ago

The # is a start-of-comment character in Makefiles. This commit changes sed to use , instead, as otherwise things break with

unterminated call to function 'notdir': missing ')'.  Stop.
alerque commented 4 years ago

Good catch, and thanks for contributing the fix! If memory serves me the handling of comment characters in contexts like this was actually fixed in GNU Make 4.3 which is why it's been working fine for me (and in Docker) but it's great to have compatibility with older versions of make.

alerque commented 4 years ago

Before I can merge this I have to ask ... the project as posted right now is licensed AGPL. There is a good chance than I'll kind of be bullied into changing this to be GPL before font projects that want to be published on Google Fonts can use this without making a scene (see #35). Since tracking down contributors after the fact to approve a license change is a hassle, can I just ask up front if you'll be willing to have your contributions re-licensed as GPL-3 were I to make the decision to do so?

d125q commented 4 years ago

Hi, and thanks for getting back so quickly! I am absolutely fine with having my contributions re-licensed as GPLv3.