search

thelema / odb

Oasis-db downloader and installer
Do What The F*ck You Want To Public License
33 stars 7 forks source link

reqs should be a string set #64

Closed UnixJunkie closed 12 years ago

UnixJunkie commented 12 years ago

Hello,

reqs were a list initially but time has come for a set. For example, there were duplicates being printed out after a odb.ml --force [some_package]

Maybe, one day, they will even become nodes in a graph and it will open a lot of possibilities in order to manage the set of installed packages in an even better way.

Regards, F.

thelema commented 12 years ago

Merged (squashed) in commit 06f5ff5e9ff hmm, sorry for taking credit for your code, please send pull requests with a single commit.

UnixJunkie commented 12 years ago

OK.

Do you have one way to convert a whole branch as a pull request with a single commit?

My way of working is to do micro commits to the source code and to give each one an explanatory commit message.

I don't work anymore with single large commits, since I worked on some repositories that were moving really fast with several developers in intricated parts.

Also, I produce less bugs in this way since I try to carefully re-read the diff of each commit. If commits are small, it is easier to spot errors. Also, it makes the git bisect command more useful.

Regards, F.

thelema commented 12 years ago

I'm fine with your way of doing tiny commits, I just find it easier to have slightly larger commits without the incomplete steps for pulling. I use git merge --squash to produce a single squash commit that has the whole merge result.