MaterialDataManager: Enable to integrate with behaviour options through C and Fortran bindings

thelfer / MFrontGenericInterfaceSupport

This project aims at providing support for MFront generic behaviours. This project can be embedded in open-source and propriary sofware

37 stars 35 forks source link

MaterialDataManager: Enable to integrate with behaviour options through C and Fortran bindings #122

Closed pbouda95 closed 10 months ago

pbouda95 commented 1 year ago

A first response to issue #120

thelfer commented 10 months ago

Sorry @pbouda95, this MR got totally unnoticed. I am very sorry. Thanks for this great work !

thelfer commented 10 months ago

For some reasons, you change the order of two parameters in the integrate method. I stepped back for backward compatibility and for consistency with the TFEL/MGIS conventions: always make mutable arguments on the left of the argument list

pbouda95 commented 10 months ago

Hello @thelfer,

Glad to see that this dev was useful ! Concerning the parameters order in the integrate method, I did not remember well why I did that but whatever ... I will keep in mind the aforementioned conventions for the next time !

Cheers,

thelfer commented 10 months ago

Thanks again for your contribution !