thelfer / MFrontGenericInterfaceSupport

This project aims at providing support for MFront generic behaviours. This project can be embedded in open-source and propriary sofware
37 stars 35 forks source link

Feature request: Support for MFront parameters #2

Closed chleh closed 5 years ago

chleh commented 5 years ago

First of all thanks for this library, based on the unit tests we could implement MFront support into our FEM code in seven days, including tests. Especially your unit tests were really helpful.

I recognized that Behaviour::parameters is always empty. There is some code to parse the parameters from MFront behaviour libraries https://github.com/thelfer/MFrontGenericInterfaceSupport/blob/9b0884a042c288d4d6ac55db458ec851dc1b1b89/src/Behaviour.cxx#L286 However, it's commented and seems somewhat outdated. Are you planning to implement support for parameters in the near future?

thelfer commented 5 years ago

Hi @chleh, Thanks for using MGIS ! This library is still young, so it does have a few shortcomings, like parameters' support. I'll implement this rapidely. Beware that, do to the support of the stored and disspated energies, you must use the development branches of TFEL to use the development branches of MGIS. Do no hesitate to make other feed-backs or feature requests. Best, Thomas

thelfer commented 5 years ago

Initial support for parameters has been merged in the master branch.

The Behaviour class now has the following members:

The parameters' values can be changed through the setParameters functions in C++.

Appropriate bindings have been made for python.

What is missing:

chleh commented 5 years ago

That was really fast, thanks. We'll test that. For me the issue is solved now.

thelfer commented 5 years ago

Just add tests on parameters.

thelfer commented 5 years ago

Bindings and tests are now ok. I'l merge master and rliv-1.0 branches and close the issue.