theli-ua / garenahon

Launcher to use Heroes of Newerth native Linux client to connect to Garena HoN
31 stars 17 forks source link

Python3 #3

Closed dvdscripter closed 11 years ago

dvdscripter commented 11 years ago

Your code isn't running well under py3. Remove py3 support or really waste some time on it.

thiagojedi commented 11 years ago

Confirming the py3 bug.

There's a exception when I run with python3:

127.0.0.1 - - [17/Nov/2012 02:26:04] "POST /patcher/patcher.php HTTP/1.1" 200 -
----------------------------------------
Exception happened during processing of request from ('127.0.0.1', 49789)
Traceback (most recent call last):
  File "/usr/lib/python3.2/socketserver.py", line 295, in _handle_request_noblock
    self.process_request(request, client_address)
  File "/usr/lib/python3.2/socketserver.py", line 321, in process_request
    self.finish_request(request, client_address)
  File "launcher.py", line 292, in finish_request
    HTTPServer.finish_request(self, request, client_address)
  File "/usr/lib/python3.2/socketserver.py", line 334, in finish_request
    self.RequestHandlerClass(request, client_address, self)
  File "/usr/lib/python3.2/socketserver.py", line 648, in __init__
    self.handle()
  File "/usr/lib/python3.2/http/server.py", line 396, in handle
    self.handle_one_request()
  File "/usr/lib/python3.2/http/server.py", line 384, in handle_one_request
    method()
  File "launcher.py", line 320, in do_POST
    self.wfile.write(dumps(latest_version))
  File "launcher.py", line 181, in dumps
    return _serialize(data, False)
  File "launcher.py", line 159, in _serialize
    if isinstance(obj, basestring):
NameError: global name 'basestring' is not defined
----------------------------------------

I think it'll be helpfull...

theli-ua commented 11 years ago

tbh, I dont think py3 support was ever advertised at all though I will fix it

theli-ua commented 11 years ago

fixed with d3df61ac57