Society code (com_soc) doest not support dashes

thelia-modules / CmCIC

A Thelia payment module for Crédit Mutuel, CIC, Neuflize OBC and Monetico

GNU General Public License v3.0

4 stars 19 forks source link

Society code (com_soc) doest not support dashes #19

Closed GhaziBahri closed 5 years ago

GhaziBahri commented 5 years ago

I tried to add my Society code (com_soc) that contains a dash but it seems that the regex patern declared in preg_match ( ) function in Controller CmcicSaveConfig.php does not match with such Society code.

An esay fix would be to add \- to the patern :

https://github.com/GhaziBahri/CmCIC/pull/1/commits/6e03f55b6edf86a02805d515dc9fd0a21b50ad61#diff-3f8b2df039483a55cfd85890422a1153R88

roadster31 commented 5 years ago

Could you please submit a PR ?

GhaziBahri commented 5 years ago

Done :)

roadster31 commented 5 years ago

Solved by #20