thellmund / Android-Week-View

Display highly customizable calendar views in your Android app
Apache License 2.0
188 stars 97 forks source link

EmptyViewLongPress called on EventLongPress #92

Closed lakhwinderdebut closed 5 years ago

lakhwinderdebut commented 5 years ago

Description I set long-press listeners on week view

    weekView?.emptyViewLongPressListener = this
    weekView?.setEventLongPressListener(this)

But when I long press on event, both eventLongPress & emptyViewLongPress gets called

To Reproduce Steps to reproduce the behavior:

  1. Set an event at some time after the current time.
  2. Long press on an empty view(No Event Set), emptyViewLongPressListener gets called
  3. Now long-press on an event, emptyViewLongPressListener also gets called along with eventLongPressListener

Expected behavior A respected listener must be called only, eventLongPress: eventLongPressListener emptyViewLongPress: emptyViewLongPressListener

Additional context

thellmund commented 5 years ago

Thanks for reporting, @lakhwinderdebut! I was missing a simple return 🤦‍♂ Fixed it in 5aed30c03f9e7474ec2e60b8971ac0da88f02ce7 and will release it as part of version 4.0.

lakhwinderdebut commented 5 years ago

Thanks, @thellmund , I really appreciate the response time. Thanks for this lovely library

BTW when should we expect the release of 4.0

thellmund commented 5 years ago

Probably around mid-August.