thelondonsmiths / Solex_ser_recon_EN

Solar disc reconstruction from spectroheliograph (SHG) video files
GNU General Public License v3.0
17 stars 4 forks source link

read SHG.ini... need to reshape ? #15

Closed djibb closed 2 years ago

djibb commented 2 years ago

Hi, I've adding some option (in my git fork) from cli. But... it's not easy, because there are some options that are in options{} variable, but not in ini files, it's non documented, so which is in options, which is not etc. I think ini file should be a copy of options{} + serfiles path.

The + : readable, auto-documented, editable, copy of heart of software (JSON file) The - : break compatibility with <=3.5 version

To be honest, I don't think lots of people re-use SHG.ini with old SER files. So, this can be almost without any consequences.

So, i will not produce a pull request on it, but wait your reflexion on this, and begin to code a JSON extraction.

djibb commented 2 years ago

So... I've done this here : https://github.com/djibb/Solex_ser_recon_EN/tree/SHG_INI_JSON

thelondonsmiths commented 2 years ago

I have now implemented this. It makes some things simpler. Thanks for the suggestion.