search

thelonious / kld-intersections

A library of intersection algorithms covering all SVG shape types
BSD 3-Clause "New" or "Revised" License
343 stars 55 forks source link

- Lint README #40

Closed brettz9 closed 5 years ago

brettz9 commented 5 years ago

Btw, if you ever add @example tags within the code, ash-nazg can lint that too (just as this PR adds for Markdown files' JavaScript blocks)...

thelonious commented 5 years ago

Thanks for the fixes. BTW, what's the rational for querySelector vs getElementById?

brettz9 commented 5 years ago

I have seen one prominent dev suggest getElementById could even be deprecated in the future, though for backward-compatibility I'd sure hope not... But it is a good practice I think as one can more consistently search one's code if one follows one form and querySelector is more capable...