search

thelounge / thelounge-archlinux

📦 Arch Linux package for The Lounge
https://aur.archlinux.org/packages/thelounge/
MIT License
4 stars 5 forks source link

Fix network not available on boot #12

Closed Superpiffer closed 5 years ago

Superpiffer commented 5 years ago

Very often, on boot, TheLounge cannot connect to channels because network is not available yet. Use network-online.target solves the problem.

brunnre8 commented 5 years ago

Do you have some examples where this is done on Arch? even apache just depends on network.target

the freedesktop docs also say

It is strongly recommended not to pull in this target too liberally: for example network server software should generally not pull this in (since server software generally is happy to accept local connections even before any routable network interface is up)

xPaw commented 5 years ago

I agree with @brunnre8 it's not entirely a good idea to use this.

I suggest creating an issue in https://github.com/kiwiirc/irc-framework/issues suggesting to enable auto reconnects for specific socket errors like (EHOSTUNREACH), but even then I'm not sure if that's a good idea either.

Superpiffer commented 5 years ago

Ok, I'm already using an override so there's no problem for me. So? It's a limitation of the framework and there's nothing we can do? When my server restarts, I have to connect manually to my channels every time...

brunnre8 commented 5 years ago

there's already an issue open about it https://github.com/kiwiirc/irc-framework/issues/178

Or not quite but similar enough I guess

Superpiffer commented 5 years ago

Do you have some examples where this is done on Arch? even apache just depends on network.target

the freedesktop docs also say

It is strongly recommended not to pull in this target too liberally: for example network server software should generally not pull this in (since server software generally is happy to accept local connections even before any routable network interface is up)

BTW I just checked, nginx has both targets in the service file from the official package: https://git.archlinux.org/svntogit/packages.git/tree/trunk/service?h=packages/nginx

brunnre8 commented 5 years ago

Closing as per the discussion above.

but thanks for the PR anyhow, it's appreciated