search

thelounge / thelounge-docker

🐳 ‎ ‎Docker image for The Lounge, a self-hosted web IRC client
https://ghcr.io/thelounge/thelounge
MIT License
306 stars 73 forks source link

Add documentation for building an image #143

Closed platta closed 2 years ago

platta commented 2 years ago

Include instructions for incorporating build dependencies when building on architectures that no longer have pre-compiled binaries available.

MaxLeiter commented 2 years ago

Thanks @platta! This looks good to me but I'll leave for @williamboman to merge

williamboman commented 2 years ago

Hello! Huh, I thought this issue was resolved with the updates to the sqlite3 dependency, guess I didn't research it enough. All images built in this repo should support the sqlite3 extension, and so if having to build native extensions in some cases is needed then that's fine. Let's simply re-add the node-gyp build deps instead! I think an error in the test suite fooled me into thinking things were fine, fixing it in #144.

williamboman commented 2 years ago

Or now I think I remember. These build deps used to be installed (see the Dockerfile for the latest stable tag 4.3.1). I removed them in #142 for reasons I can no longer remember (but I'd like to think it was for a good reason). So if you want to build an image for a specific version it's best to check out that tag in this repository as well.

platta commented 2 years ago

That makes sense. I should simply close this PR then, right?

williamboman commented 2 years ago

That makes sense. I should simply close this PR then, right?

Yeah let's close this one. Thanks for bringing attention to this!