Look into adding touch-action to styles

thelounge / thelounge

💬 ‎ Modern, responsive, cross-platform, self-hosted web IRC client

https://thelounge.chat

MIT License

5.59k stars 682 forks source link

Look into adding touch-action to styles #1035

Closed xPaw closed 7 years ago

xPaw commented 7 years ago

https://developers.google.com/web/tools/lighthouse/audits/passive-event-listeners https://developer.mozilla.org/en-US/docs/Web/CSS/touch-action

This could improve performance and remove click delays. For example message and user list containers can only scroll up and down, so there is no need to handle vertical panning gestures.

Our viewport has user-scalable="no", so we could get rid of pinch-zoom too.

astorije commented 7 years ago

Good idea, though I don't see myself taking that up anytime soon, so I will remove my assignment for now. If anyone wants to take this up, please do.

iamstratos commented 7 years ago

I think I could help you. It's my first contribution though. Is it a css job?

MaxLeiter commented 7 years ago

Should be just CSS, @iamstratos. If you need any help, be sure to hop onto #thelounge on freenode and ask any questions.

astorije commented 7 years ago

That would greatly appreciated @iamstratos, thanks!

iamstratos commented 7 years ago

Should I PR to master or another branch?

MaxLeiter commented 7 years ago

To master, @iamstratos