search

thelovelab / fishpond

Differential expression and allelic analysis, nonparametric statistics
https://thelovelab.github.io/fishpond
27 stars 9 forks source link

Redesigned loadFry function #11

Closed DongzeHE closed 2 years ago

DongzeHE commented 2 years ago

Hi @mikelove, @varix, and @lianos,

I have tried my best to integrated all the sophisticated changes you all made for loadFry() to make it more flexible and easy to use. Please let me know if you have any suggestions.

Dongze

lianos commented 2 years ago

Nice work, @DongzeHE ... sorry I missed the earlier action on refactoring to better specify how to handle the counts ... I know this PR is already merged, and don't want to create another one, but I did catch a few things in here that may have slipped through that I thought was worth commenting on so will add those now, but feel free to ignore if I'm off base.

mikelove commented 2 years ago

I addressed Steve's two doc-related review items here: 01c5de7