search

thelovelab / fishpond

Differential expression and allelic analysis, nonparametric statistics
https://thelovelab.github.io/fishpond
27 stars 9 forks source link

Better column names #27

Closed jgilis closed 2 years ago

jgilis commented 2 years ago

Hi Mike,

I've been working with equivalence classes again, and noticed that when multiple paths (multiple samples) are given to alevinEC, the column names are still just the cellular barcodes, which are (1) not necessarily unique across samples and (ii) do not directly tell to which sample the barcode belongs. So now I internally append _i to the barcodes, where i is the sample (path) number.

Note: I didn't bump date and version.

Kind regards,

Jeroen

mikelove commented 2 years ago

Sounds good. Congrats on the satuRn revision going up.

jgilis commented 2 years ago

Thanks Mike! :pray:

mikelove commented 2 years ago

For some reason this test failed on my end, with latest code loaded, could you check it out?

https://github.com/mikelove/fishpond/blob/master/tests/testthat/test_alevinEC.R#L45-L46