thelovelab / tximport

Transcript quantification import for modular pipelines
134 stars 33 forks source link

can't read alevin output from salmon 0.14.0 #32

Closed alexvpickering closed 5 years ago

alexvpickering commented 5 years ago

Tried with latest version of tximport installed with devtools::install_github("mikelove/tximport") 1.13.3

tximport::tximport(file.path(alevin_dir, 'quants_mat.gz'), type = 'alevin')

Error in mat[, j] <- readBin(con, double(), endian = "little", n = num.genes) : 
  number of items to replace is not a multiple of replacement length 

Probably related to this:

The binary output format of alevin, quants_mat.gz, has been changed into a sparse single precision format. In pratice we saw the file size reduced to as big as half the size of the original file.

k3yavi commented 5 years ago

Hi @alexvpickering ,

Thanks for the issue. We are still working on this, in the meantime, I will share a workable version soon.

mikelove commented 5 years ago

Thanks for this report. We’ll take a look. @k3yavi and I have a meeting already for tomorrow to discuss the next iteration of the Alevin file format. And we can figure out how tximport needs to change to accommodate Salmon 0.14.

k3yavi commented 5 years ago

Hi @alexvpickering ,

Thanks again for raising the issue. As requested by one other user too, we have a shared a basic (non-optimized) R parser for the alevin 0.14.0 output in this https://github.com/COMBINE-lab/salmon/issues/380 thread. We are still working on optimizing the parser and integrating it with tximport and will update you once it is stable.

mikelove commented 5 years ago

Status update: I'm creating some test data for 0.14 so I can bring in Avi's code into tximport

mikelove commented 5 years ago

I’ve got a little code but didn’t finish today and want to put in a unit test alongside the new code.

mikelove commented 5 years ago

Thanks for notifying us quickly to this issue.

Should be fixed by 6f761a7670ad5352b4e8a5bbf434c6b0146cbb8a

You can obtain the new code with install_github("mikelove/tximport"). If you can test that it works on your end, i'll push it to release as well.

mikelove commented 5 years ago

I just pushed 1.12.2 to release branch as well, so it gets circulated tomorrow

k3yavi commented 5 years ago

Thanks @mikelove !