thelsing / knx

knx stack (TP, IP and RF) for arduino and linux, Can be configured with ETS
GNU General Public License v3.0
276 stars 95 forks source link

Openknx version support #190

Closed mumpf closed 2 years ago

mumpf commented 2 years ago

This change extends version checking of memory content at startup:

Additionally a versionCheckCallback is added, which allows to check memory content on firmware level.

There is one possible side effect of this change: If someone implemented a version check, which relies on Dataobject::version() property, this will not work in future anymore. A possible solution is to use DataObject::hardwareType() instead or implement the old behaviour in an own versionCheckCallback-Handler.

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging 3886fa5e9fdfe393196781ff6685fb16ea404e26 into a10fa20bde3b70413a74af5e750ba18801520029 - view on LGTM.com

new alerts:

mumpf commented 2 years ago

Should now be ok. Hope so...

mumpf commented 2 years ago

Hi, I hope that was the final one...

Thank for your support.

thelsing commented 2 years ago

Merged. Thanks.