FIX: float16ToPayload - Githubissues

thelsing / knx

knx stack (TP, IP and RF) for arduino and linux, Can be configured with ETS

GNU General Public License v3.0

257 stars 91 forks source link

FIX: float16ToPayload #257

Closed mumpf closed 10 months ago

mumpf commented 10 months ago

all DPT9 numbers of the form (2^n)/100, n>10 (first value is 20.48) were converted to a payload of 0
in other words: 20.48; 40.96; 81.92; etc. were send as 0! Fix is tested and works fine. First time I got a bug report regarding this error was 3 years ago. At this time I couldn't reproduce...

Please merge this fix. Thanks. Waldemar

mumpf commented 10 months ago

Just a remark: I tested the fix also with negative numbers and also the reverse function float16FromPayload (in case there is this error, too). Everything works now fine!

mumpf commented 10 months ago

After additional tests there were still some rounding problems. Improved correction and did a test with full numeric range of DPT9. Finally, just value 0 results in a payload 0.