search

thelsing / knx

knx stack (TP, IP and RF) for arduino and linux, Can be configured with ETS
GNU General Public License v3.0
257 stars 91 forks source link

Allow Setting Value of Group-Object with Sending Changed Converted Value Only #258

Closed cornelius-koepp closed 6 months ago

cornelius-koepp commented 10 months ago

Will check based on changed value after conversion.

Calling valueModifiedSend(value, type) with different values will only send, if value represented in given dpt is not the same.

thelsing commented 10 months ago

Is there any reason that you marked this PR as draft? Do you still want to change something?

cornelius-koepp commented 10 months ago

because there is already the value method, which clearly sends a value.

The value(..)-method should be preferred when the knowlege of object value changed is not relevant.

forceSend [...] should be handled together with Uninitialized.

By handling the same way as Uninitialized, there would be no feeback of object value change and no advantage in comparison to value(..).

cornelius-koepp commented 10 months ago

Is there any reason that you marked this PR as draft? Do you still want to change something?

Yes, the 'draft' state was intended, to have the room for optimizations, feedback (for this hopefully generically usable extension of public group-object-api) and further testing. Optimization and feedback seen yesterday.

cornelius-koepp commented 6 months ago

Replaced by #272 with checking for update only.