Fix: Group-Object `_commFlag != Uninitialized` does NOT Guarantee an Actual Initialization - Githubissues

thelsing / knx

knx stack (TP, IP and RF) for arduino and linux, Can be configured with ETS

GNU General Public License v3.0

257 stars 91 forks source link

Fix: Group-Object `_commFlag != Uninitialized` does NOT Guarantee an Actual Initialization #279

Open cornelius-koepp opened 5 months ago

cornelius-koepp commented 5 months ago

Issue:

The differentiation between uninitialized and initialized state can NOT be represented correctly in ComFlag alone:

it might be in state Transmitting during a ReadRequest on startup while value is still not valid

Solution:

Add a separate uninitialized flag to overcome the limitations of ComFlag.

Compatibility:

We use MSB to store uninitialized state and keep the size of GroupObject the same saving memory resources.
The old uninitialized handling is not changed for compatibility reasons.

Tested Platforms:

[X] RP2040
No Issues Reported
[X] SAMD
[X] ESP32

cornelius-koepp commented 4 months ago

No abnormalities reported for SAMD and ESP32; removing draft state.