them-es / starter-bootstrap

Bootstrap 5 WordPress Starter Theme.
https://them.es/starter-bootstrap
GNU General Public License v2.0
149 stars 53 forks source link

Deprecated dependencies? #22

Closed yurg closed 2 years ago

yurg commented 2 years ago

Thank you for the theme, clean and simple! By running npm install we ran into a few deprecations, please see below. Would this be something worth fixing on the theme distribution level or you advise is to get all fixes via NPM after npm install please?

npm install
npm WARN deprecated chokidar@2.1.8: Chokidar 2 does not receive security updates since 2019. Upgrade to chokidar 3 with 15x fewer dependencies
npm WARN deprecated source-map-resolve@0.6.0: See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated fsevents@1.2.13: fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.
npm WARN deprecated stable@0.1.8: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility
npm WARN deprecated source-map-resolve@0.5.3: See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated source-map-url@0.4.1: See https://github.com/lydell/source-map-url#deprecated

> es5-ext@0.10.62 postinstall /home/wp-content/themes/bootstrap-52/node_modules/es5-ext
>  node -e "try{require('./_postinstall')}catch(e){}" || exit 0

npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@~2.3.2 (node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.3.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@^1.2.7 (node_modules/glob-watcher/node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.13: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN ws@8.2.3 requires a peer of bufferutil@^4.0.1 but none is installed. You must install peer dependencies yourself.
npm WARN ws@8.2.3 requires a peer of utf-8-validate@^5.0.2 but none is installed. You must install peer dependencies yourself.
npm WARN postcss-load-config@3.1.4 requires a peer of ts-node@>=9.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN acorn-import-assertions@1.8.0 requires a peer of acorn@^8 but none is installed. You must install peer dependencies yourself.

added 678 packages from 549 contributors and audited 680 packages in 62.227s
found 2 high severity vulnerabilities
  run `npm audit fix` to fix them, or `npm audit` for details
them-es commented 2 years ago

Hi @yurg,

thanks for the feedback. All third-party dependencies have been updated to the latest versions available: https://github.com/them-es/themes-starter-bootstrap/commit/52e39f3278dd0f67c998dbebef4e5f5d922bb886

If you still encounter an issue with deprecation warnings you'd have to inform the maintainers of the respective modules to update their code base. Alternatively you can use a different setup to bundle your frontend assets: https://getbootstrap.com/docs/5.2/getting-started/webpack/ or whatever you prefer.

yurg commented 2 years ago

@them-es Thank you for the update and https://getbootstrap.com/docs/5.2/getting-started/webpack/ pointer!