Remove redundant slash in artifactURL

themadcreator / circle-github-bot

CircleCI comments on github

Apache License 2.0

58 stars 14 forks source link

Remove redundant slash in artifactURL #10

Closed pirate closed 7 years ago

pirate commented 7 years ago

env.home already starts with a / because it's an absolute file path.

Currently it's producing urls like: https://circleci.com/gh/user/project/999/artifacts/0//home/ubuntu/proj/screenshots/home.png

pirate commented 7 years ago

Sorry, you can close this PR. I was having issues with artifacts images not rendering in github comments, and I though the weird urls could've been the cause. Turns out build artifacts aren't publicly accessible (rightly so), and it prevents github from proxying the images. I wish there were a way to inline render them directly, but it appears all github content images are force-proxied.