search

themadinventor / ida-xtensa

IDAPython plugin for Tensilica Xtensa (as seen in ESP8266)
GNU General Public License v2.0
166 stars 46 forks source link

Improve control flow discovery #2

Closed pfalcon closed 9 years ago

pfalcon commented 9 years ago

Please consider applying this patch, which is essentially reverting stuff added previously to workaround issues, instead of solving them properly. (For example, CF_CALL was removed from "call0" probably because of presence of "ill", but the proper fix was to disable non-instruction "ill".)

Full disclosure: I don't test this with IDA, instead I test it with a shiny new tool called https://github.com/pfalcon/ScratchABit , which I invite wider community to try. (But the changes proposed are generic disassembly control flow changes, and should have only positive effect, except you may want to test them with IDA if you're in doubt.)

themadinventor commented 9 years ago

Thanks for bringing this up, I reverted the CF_CALL flag locally after a while but forgot to push. Shame on me for not testing it enough in the first place. :)